Skip to content

Conversation

@ovitrif
Copy link
Collaborator

@ovitrif ovitrif commented Jan 26, 2026

This PR:

  1. Adds proper backup rules for Android 9-11 and data extraction rules for Android 12+
  2. Suppresses Android 14+ foreground service lint warnings
  3. Configures ABI splits to generate architecture-specific APKs
  4. Unifies build output naming for APKs and AABs

Description

Backup Configuration

  • Adds backup_rules.xml for Android 9-11 (fullBackupContent) with all domains excluded
  • Adds data_extraction_rules.xml for Android 12+ (dataExtractionRules) with empty sections to disable cloud backup and device transfer
  • Adds both manifest attributes for complete backward compatibility

Foreground Service

  • Suppresses ForegroundServicePermission and ForegroundServicesPolicy lint warnings since the configuration is correct (the warning is informational about Play Console requirements)

Build Outputs

  • Enables ABI splits for armeabi-v7a and arm64-v8a architectures
  • Generates universal APK as fallback
  • Unifies naming format: bitkit-{flavor}-{buildType}-{versionCode}[-abi].apk/aab

Preview

N/A - No UI changes.

QA Notes

  1. Verify build outputs

    ./gradlew assembleMainnetRelease
    ls app/build/outputs/apk/mainnet/release/

    Expected files:

    • bitkit-mainnet-release-173-arm64-v8a.apk
    • bitkit-mainnet-release-173-armeabi-v7a.apk
    • bitkit-mainnet-release-173-universal.apk
  2. Verify AAB naming

    ./gradlew bundleMainnetRelease
    ls app/build/outputs/bundle/mainnetRelease/

    Expected: bitkit-mainnet-release-173.aab

  3. Verify no lint warnings

    • Open AndroidManifest.xml in Android Studio
    • Confirm no warnings on foreground service permission line

@ovitrif
Copy link
Collaborator Author

ovitrif commented Jan 26, 2026

FYI this is the commit on which 173 (store submission) is built on: 56d6a23

EDIT:

@ovitrif ovitrif enabled auto-merge January 26, 2026 23:05
@claude

This comment has been minimized.

@claude

This comment has been minimized.

@claude

This comment has been minimized.

chore: update ldk-node to backport electrum sync fix
Copy link
Contributor

@ben-kaufman ben-kaufman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utAck

@ovitrif ovitrif merged commit b035334 into master Jan 27, 2026
14 checks passed
@ovitrif ovitrif deleted the release/173 branch January 27, 2026 11:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants